Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 96.15% 97.75% +1.59%
==========================================
Files 1 1
Lines 78 89 +11
==========================================
+ Hits 75 87 +12
+ Misses 3 2 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| service_status_ret = self._call( | ||
| self.url, "ServiceWizard.get_service_status", | ||
| [{"module_name": service, "version": service_version}] | ||
| ) | ||
| return service_status_ret["url"] |
There was a problem hiding this comment.
This is a direct port from the baseclient in the SDK, but looking at this now, it's be a good idea to put a ~1 min LRU cache around this part of the method at some point.
| assert res == { | ||
| 'git_url': 'https://github.com/kbaseapps/HTMLFileSetServ', | ||
| 'message': '', | ||
| 'state': 'OK', | ||
| } |
There was a problem hiding this comment.
are these live calls or is there some mocking machinery hidden elsewhere in the file?
Highly recommend vcrpy for testing against external services without having to test against external services.
There was a problem hiding this comment.
They're live calls. I'd much rather test against a real service than a mock, especially when it's relatively easy like this case
2 participants
No description provided.